Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clipping issue with 2 image grid #5744

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix clipping issue with 2 image grid #5744

wants to merge 1 commit into from
+1 −12

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Oct 14, 2024

Simply removes the aspect ratio of the container, since it didn't account for the gap

Before After
Screenshot 2024-10-14 at 13 29 19 Screenshot 2024-10-14 at 13 29 32

@github-actions GitHub Actions
Copy link

Old size New size Diff
7.9 MB 7.9 MB -39 B (-0.00%)

haileyok
haileyok reviewed Oct 14, 2024
View reviewed changes
src/view/com/util/images/ImageLayoutGrid.tsx
aspectRatio = undefined
break
}
let aspectRatio = count === 3 ? 2 : undefined
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileyok haileyok haileyok left review comments

@estrattonbailey estrattonbailey estrattonbailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mozzius @estrattonbailey @haileyok @arcalinea