chore: switch to slog for logging #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agaffney
requested changes
Sep 23, 2024
api/api_test.go
Outdated
| @@ -20,13 +21,15 @@ func TestRouteRegistration(t *testing.T) { | |||
| if registrar, ok := interface{}(pushPlugin).(api.APIRouteRegistrar); ok { | |||
| registrar.RegisterRoutes() | |||
| } else { | |||
| t.Fatal("pushPlugin does NOT implement APIRouteRegistrar") | |||
| t.Error("pushPlugin does NOT implement APIRouteRegistrar") | |||
| os.Exit(1) | |||
There was a problem hiding this comment.
We should leave this as it was. It's not related to slog, and there's no reason to change it.
api/api_test.go
Outdated
| } | ||
|
|
||
| // Create a test request to one of the registered routes | ||
| req, err := http.NewRequest(http.MethodGet, "/v1/fcm/someToken", nil) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| t.Error(err) | ||
| os.Exit(1) |
There was a problem hiding this comment.
We should leave this as it was. It's not related to slog, and there's no reason to change it.
cmd/adder/main.go
Outdated
|
|
||
| // Start debug listener | ||
| if cfg.Debug.ListenPort > 0 { | ||
| logger.Infof( | ||
| logger.Info( |
There was a problem hiding this comment.
This needs an inner fmt.Sprintf()
Signed-off-by: Ales Verbic <verbotenj@blinklabs.io>
verbotenj
force-pushed
the
chore/change-to-slog
branch
from
a0bcbe0
to
dc690d0
Compare
agaffney
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152