MB-62230 - Pre-Filtering Support for kNN #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
metonymic-smokey
commented
Aug 12, 2024
•
metonymic-smokey
commented
- Extended KNN queries to support filter queries if specified.
- Created a new collector, eligible collector, and a new document match handler for the filter queries as part of kNN.
- Run the filter queries prior to each kNN query and pass the results when constructing the kNN queries.
- Added unit tests for filtered kNN cases.
- Updated the documentation with an example of a filtered kNN request.
metonymic-smokey
force-pushed
the
pre-filter
branch
from
9cc3688
to
c73c827
Compare
metonymic-smokey
requested review from
abhinavdangeti,
Thejas-bhat,
CascadingRadium,
Likith101 and
moshaad7
abhinavdangeti
requested changes
Aug 20, 2024
metonymic-smokey
force-pushed
the
pre-filter
branch
from
2904fac
to
0b90c1e
Compare
metonymic-smokey
force-pushed
the
pre-filter
branch
from
0b90c1e
to
0c6dcf4
Compare
Thejas-bhat
previously approved these changes
Aug 29, 2024
abhinavdangeti
requested changes
Sep 9, 2024
There was a problem hiding this comment.
@metonymic-smokey no force pushing here please, checkout latest from branch pre-filter before pushing commits up. There're unit tests failing that needs looking into -
--- FAIL: TestSimilaritySearchPartitionedIndex (0.31s)
search_knn_test.go:876: test case #0 failed: 0 hits returned
--- FAIL: TestSimilaritySearchMultipleSegments (0.27s)
search_knn_test.go:876: test case #0 failed: 0 hits returned
abhinavdangeti
requested changes
Sep 10, 2024
abhinavdangeti
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.