Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MB-62354: Support Cosine Similarity #2051

Merged
merged 5 commits into from
Aug 5, 2024
Merged

MB-62354: Support Cosine Similarity #2051

merged 5 commits into from
Aug 5, 2024

Conversation

CascadingRadium
Copy link
Member

  • Normalize the query vector if the Similarity Metric is cosine
  • Add unit test cases for Cosine Similarity

@abhinavdangeti abhinavdangeti added this to the v2.4.2 milestone Jul 9, 2024
@abhinavdangeti abhinavdangeti modified the milestones: v2.4.2, v2.4.3 Jul 25, 2024
abhinavdangeti
abhinavdangeti requested changes Aug 5, 2024
View reviewed changes
Copy link
Member

@abhinavdangeti abhinavdangeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bring the normalization on the index paths to here when we interpret the vector.

@abhinavdangeti abhinavdangeti merged commit 4920071 into master Aug 5, 2024
9 checks passed
@abhinavdangeti abhinavdangeti deleted the cosine branch August 5, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdangeti abhinavdangeti abhinavdangeti approved these changes

@Thejas-bhat Thejas-bhat Awaiting requested review from Thejas-bhat

@metonymic-smokey metonymic-smokey Awaiting requested review from metonymic-smokey

@Likith101 Likith101 Awaiting requested review from Likith101

@moshaad7 moshaad7 Awaiting requested review from moshaad7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@CascadingRadium @abhinavdangeti