code review

index.go

@@ -47,7 +47,7 @@ func (b *Batch) Index(id string, data interface{}) error {
 		return ErrorEmptyID
 	}
 	if eventIndex, ok := b.index.(index.EventIndex); ok {
-		eventIndex.FireEvent(index.EventKindIndex)
+		eventIndex.FireIndexEvent()
 	}
 	doc := document.NewDocument(id)
 	err := b.index.Mapping().MapDocument(doc, data)

index/scorch/scorch.go

@@ -878,16 +878,8 @@ func (s *Scorch) CopyReader() index.CopyReader {
 	return rv
 }
 
-// external API to fire a scorch event externally from bleve
-func (s *Scorch) FireEvent(eventKind index.EventKind) {
+// external API to fire a scorch event (EventKindIndexStart) externally from bleve
+func (s *Scorch) FireIndexEvent() {
 	// switch on bleve the event kind and fire the corresponding scorch event
-	switch eventKind {
-	case index.EventKindIndex:
-		// bleve is about to index a document using the Index() API
-		// fire the corresponding scorch event
-		s.fireEvent(EventKindIndexStart, 0)
-	default:
-		// do nothing
-		return
-	}
+	s.fireEvent(EventKindIndexStart, 0)
 }

index_impl.go

@@ -255,7 +255,7 @@ func (i *indexImpl) Index(id string, data interface{}) (err error) {
 	if !i.open {
 		return ErrorIndexClosed
 	}
-	i.FireEvent(index.EventKindIndex)
+	i.FireIndexEvent()
 	doc := document.NewDocument(id)
 	err = i.m.MapDocument(doc, data)
 	if err != nil {
@@ -1113,15 +1113,15 @@ func (f FileSystemDirectory) GetWriter(filePath string) (io.WriteCloser,
 		os.O_RDWR|os.O_CREATE, 0600)
 }
 
-func (i *indexImpl) FireEvent(eventKind index.EventKind) {
+func (i *indexImpl) FireIndexEvent() {
 	// get the internal index implementation
 	intIndex, err := i.Advanced()
 	if err != nil {
 		return
 	}
 	// check if the internal index implementation supports events
-	if eventIntIndex, ok := intIndex.(index.EventIndex); ok {
+	if eventInternalIndex, ok := intIndex.(index.EventIndex); ok {
 		// fire the event
-		eventIntIndex.FireEvent(eventKind)
+		eventInternalIndex.FireIndexEvent()
 	}
 }