Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change logger to use ASIM format #3035

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Conversation

matthewford
Copy link
Contributor

@matthewford matthewford commented Aug 13, 2024

📝 A short description of the changes

Adding Current via ActiveSupport::CurrentAttributes for the Asim formatter to get the current user and type.

  • Enable ASIM logger in dev via ENABLE_ASIM_LOGGER env var

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

  • None

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):


@matthewford matthewford force-pushed the change-logger-format branch 3 times, most recently from 0181b43 to 0e05389 Compare August 13, 2024 11:45
@matthewford matthewford marked this pull request as ready for review August 13, 2024 11:47
Adding Current via ActiveSupport::CurrentAttributes
for the Asim formatter to get the current user and type.

* Enable ASIM logger in dev via ENABLE_ASIM_LOGGER env var
@matthewford matthewford merged commit 2da696a into main Aug 20, 2024
11 checks passed
@matthewford matthewford deleted the change-logger-format branch August 20, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants