Skip to content

Commit

Permalink
Merge pull request #3056 from bitzesty/cherrypick-form-changes
Browse files Browse the repository at this point in the history
Cherrypick form changes
  • Loading branch information
TheDancingClown authored Aug 29, 2024
2 parents ff848d0 + 00a27a4 commit b35348d
Show file tree
Hide file tree
Showing 11 changed files with 28 additions and 21 deletions.
4 changes: 4 additions & 0 deletions app/models/reports/cases_status_report.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ class Reports::CasesStatusReport
label: "CompanyOrNominee",
method: :company_or_nominee_name,
},
{
label: "Organisation Name for Certificate B4.1",
method: :brand_name,
},
{
label: "SIC Code",
method: :sic_code,
Expand Down
4 changes: 4 additions & 0 deletions app/models/reports/form_answer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,10 @@ def mso_grade_agreed
end.join(",")
end

def brand_name
@obj.document["brand_name"]
end

def sic_code
@obj.document["sic_code"]
end
Expand Down
4 changes: 2 additions & 2 deletions forms/award_years/v2025/innovation/innovation_step1.rb
Original file line number Diff line number Diff line change
Expand Up @@ -182,12 +182,12 @@ def innovation_step1
)
end

textarea :major_issues_overcome, "Please explain any major issues that you have overcome in recent years and the remedial steps you have taken." do
textarea :major_issues_overcome, "Please explain any major internal issues you have overcome in recent years and the remedial steps you have taken." do
ref "A 2.2"
classes "sub-question text-words-max"
required
context %(
<p class="govuk-body">For example, what steps did you take following a major Health and Safety incident.</p>
<p class="govuk-body">For example, what remedial steps did you take following a significant issue that affected your workforce, such as a major Health & Safety incident?</p>
)
words_max 200
end
Expand Down
4 changes: 2 additions & 2 deletions forms/award_years/v2025/innovation/innovation_step2.rb
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,14 @@ def innovation_step2
text_words_max 50
end

text :brand_name, "Organisation name as you would like it to appear on award certificate and announcements." do
text :brand_name, "Organisation name as you would like it to appear on the Royal award certificate and announcements." do
classes "sub-question text-words-max"
ref "B 4.1"
required
context %(
<p>Usually, this is the same name as your organisation's full legal name.</p>
<p>However, you may choose to include the name you are trading as or a brand name. If you do so, you may be asked to provide evidence that the legal entity uses the trading name or owns the brand. Also, the evidence in the application form must be clearly linked to the provided trading name or brand.</p>
<p>We can't grant an award to a different legal entity but can grant it to a brand or trading name of the legal entity that has passed the KAE due diligence process. If you choose a brand or trading name, you may be asked to provide evidence that the legal entity uses the trading name or owns the brand.</p>
<p>Please note that this is the name that will appear on your Award certificate if you are successful. We recommend not capitalising all letters as it may affect legibility, as the document uses an ornate typeface.</p>
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -184,12 +184,12 @@ def trade_step1
)
end

textarea :major_issues_overcome, "Please explain any major issues that you have overcome in recent years and the remedial steps you have taken." do
textarea :major_issues_overcome, "Please explain any major internal issues you have overcome in recent years and the remedial steps you have taken." do
ref "A 2.2"
classes "sub-question text-words-max"
required
context %(
<p class="govuk-body">For example, what steps did you take following a major Health and Safety incident.</p>
<p class="govuk-body">For example, what remedial steps did you take following a significant issue that affected your workforce, such as a major Health & Safety incident?</p>
)
words_max 200
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,18 +109,17 @@ def trade_step2
text_words_max 50
end

text :brand_name, "Organisation name as you would like it to appear on award certificate and announcements." do
text :brand_name, "Organisation name as you would like it to appear on the Royal award certificate and announcements." do
classes "sub-question text-words-max"
ref "B 4.1"
required
context %(
<p class="govuk-hint">Usually, this is the same name as your organisation's full legal name.</p>
<p>Usually, this is the same name as your organisation's full legal name.</p>
<p class="govuk-hint">However, you may choose to include the name you are trading as or a brand name. If you do so, you may be asked to provide evidence that the legal entity uses the trading name or owns the brand. Also, the evidence in the application form must be clearly linked to the provided trading name or brand.</p>
<p>We can't grant an award to a different legal entity but can grant it to a brand or trading name of the legal entity that has passed the KAE due diligence process. If you choose a brand or trading name, you may be asked to provide evidence that the legal entity uses the trading name or owns the brand.</p>
<p class="govuk-hint">Please note that this is the name that will appear on your Award certificate if you are successful. We recommend not capitalising all letters as it may affect legibility, as the document uses an ornate typeface.</p>
<p>Please note that this is the name that will appear on your Award certificate if you are successful. We recommend not capitalising all letters as it may affect legibility, as the document uses an ornate typeface.</p>
)
style "small"
text_words_max 50
end

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,12 +182,12 @@ def mobility_step1
)
end

textarea :major_issues_overcome, "Please explain any major issues that you have overcome in recent years and the remedial steps you have taken." do
textarea :major_issues_overcome, "Please explain any major internal issues you have overcome in recent years and the remedial steps you have taken." do
ref "A 2.2"
classes "sub-question text-words-max"
required
context %(
<p class="govuk-body">For example, what steps did you take following a major Health and Safety incident.</p>
<p class="govuk-body">For example, what remedial steps did you take following a significant issue that affected your workforce, such as a major Health & Safety incident?</p>
)
words_max 200
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,16 +106,16 @@ def mobility_step2
text_words_max 50
end

text :brand_name, "Organisation name as you would like it to appear on award certificate and announcements." do
text :brand_name, "Organisation name as you would like it to appear on the Royal award certificate and announcements." do
sub_ref "B 4.1"
classes "sub-question text-words-max"
required
context %(
<p>Usually, this is the same name as your organisation's full legal name.</p>
<p>However, you may choose to include the name you are trading as or a brand name. If you do so, you may be asked to provide evidence that the legal entity uses the trading name or owns the brand. Also, the evidence in the application form must be clearly linked to the provided trading name or brand.</p>
<p>We can't grant an award to a different legal entity but can grant it to a brand or trading name of the legal entity that has passed the KAE due diligence process. If you choose a brand or trading name, you may be asked to provide evidence that the legal entity uses the trading name or owns the brand.</p>
<p>Please note that this is the name that will appear on your Award certificate if you are successful. We recommend not capitalising all letters as it may affect legibility, as the document uses an ornate typeface.</p>
<p>Please note that this is the name that will appear on your Award certificate if you are successful. We recommend not capitalising all letters as it may affect legibility, as the document uses an ornate typeface.</p>
)
text_words_max 50
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,12 +182,12 @@ def development_step1
)
end

textarea :major_issues_overcome, "Please explain any major issues that you have overcome in recent years and the remedial steps you have taken." do
textarea :major_issues_overcome, "Please explain any major internal issues you have overcome in recent years and the remedial steps you have taken." do
ref "A 2.2"
classes "sub-question text-words-max"
required
context %(
<p class="govuk-body">For example, what steps did you take following a major Health and Safety incident.</p>
<p class="govuk-body">For example, what remedial steps did you take following a significant issue that affected your workforce, such as a major Health & Safety incident?</p>
)
words_max 200
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,14 @@ def development_step2
text_words_max 50
end

text :brand_name, "Organisation name as you would like it to appear on award certificate and announcements." do
text :brand_name, "Organisation name as you would like it to appear on the Royal award certificate and announcements." do
classes "sub-question text-words-max"
sub_ref "B 4.1"
required
context %(
<p>Usually, this is the same name as your organisation's full legal name.</p>
<p>However, you may choose to include the name you are trading as or a brand name. If you do so, you may be asked to provide evidence that the legal entity uses the trading name or owns the brand. Also, the evidence in the application form must be clearly linked to the provided trading name or brand.</p>
<p>We can't grant an award to a different legal entity but can grant it to a brand or trading name of the legal entity that has passed the KAE due diligence process. If you choose a brand or trading name, you may be asked to provide evidence that the legal entity uses the trading name or owns the brand.</p>
<p>Please note that this is the name that will appear on your Award certificate if you are successful. We recommend not capitalising all letters as it may affect legibility, as the document uses an ornate typeface.</p>
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
let(:id) { "cases-status" }
it "produces proper output" do
expect(output.size).to eq(2)
expect(output[1][9]).to eq("No")
expect(output[1][10]).to eq("No")
end
end

Expand Down

0 comments on commit b35348d

Please sign in to comment.