Skip to content

Commit

Permalink
Merge pull request #3066 from bitzesty/rag-reports
Browse files Browse the repository at this point in the history
chore: Update rag method to use descriptive labels for ratings
  • Loading branch information
TheDancingClown authored Aug 30, 2024
2 parents 9928ba2 + fa0d166 commit 64eb03c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions app/models/reports/form_answer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,9 @@ def bool(var)

def rag(var)
{
"negative" => "R",
"positive" => "G",
"average" => "A",
"negative" => "Not recommended",
"positive" => "Recommended",
"average" => "Reserved",
}[var]
end

Expand Down
2 changes: 1 addition & 1 deletion spec/models/reports/form_answer_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
it "should return correct grade" do
allow_any_instance_of(Reports::FormAnswer).to receive(:pick_assignment) { build(:assessor_assignment_moderated) }
allow_any_instance_of(Reports::FormAnswer).to receive(:pick_assignment).with("moderated") { build(:assessor_assignment_moderated, document: { w_rate_1: "positive", w_rate_2: "average" }) }
expect(Reports::FormAnswer.new(build(:form_answer)).send(:mso_grade_agreed)).to eq "G,A"
expect(Reports::FormAnswer.new(build(:form_answer)).send(:mso_grade_agreed)).to eq "Recommended,Reserved"
end
end

Expand Down

0 comments on commit 64eb03c

Please sign in to comment.