Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show readme.md in PyPi pages #2306

Closed

Conversation

drmcodes
Copy link

Description

PyPi pages changed from plain hardcoded string to render README.md

Fixes Issue:

Before Merge Checklist

These items can be completed after PR is created.

(Check any items that are not applicable (NA) for this PR)

  • [✅] JavaScript implementation
  • [✅] Python implementation (NA if HTML beautifier)
  • [✅] Added Tests to data file(s)
  • [✅] Added command-line option(s) (NA if
  • [✅] README.md documents new feature/option(s)

Copy link

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!


setup(
name="cssbeautifier",
version=__version__,
description="CSS unobfuscator and beautifier.",
long_description=("Beautify, unpack or deobfuscate CSS"),
long_description=long_description,

This comment was marked as resolved.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks

"Beautify, unpack or deobfuscate JavaScript. "
"Handles popular online obfuscators."
),
long_description=long_description,

This comment was marked as resolved.

Comment on lines 30 to 31


This comment was marked as resolved.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the inconvenience, thanks for the feedback

@@ -27,15 +27,13 @@ def run_tests(self):
errno = pytest.main(self.pytest_args)
sys.exit(errno)


This comment was marked as resolved.

@cclauss
Copy link

cclauss commented Jul 31, 2024

@bitwiseman
Copy link
Member

@drmcodes resolve conflicts, please.

@cclauss
Copy link

cclauss commented Aug 18, 2024

I do not see any remaining conflicts.

@bitwiseman
Copy link
Member

They resolved them.

@drmcodes
Copy link
Author

Thx for the feedback.

@drmcodes drmcodes closed this Aug 19, 2024
@drmcodes drmcodes deleted the fix-pypi-pages-long-description branch August 19, 2024 00:01
@cclauss
Copy link

cclauss commented Aug 19, 2024

Why was this closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants