-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default basemap to StamenTonerLight #254
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update OpenShift template with site config objects
…truck-routes-provincial-highway layers.
…routes-provincial-highway and truck-routes-provincial-highway-high-zoom layers.
Enable querying on the Provincial Highways layers in the truck route group
This addresses a javascript error when printing directions. When a layer is not visible at the current zoom level, its value in an array of visible layers is undefined, causing an error when we retrieve layers in the print function. This change tests for the visible layer and, if missing, returns a simpler layer configuration. Co-authored-by: dgboss <darren.boss@gov.bc.ca>
After further discussion with Brendan of the GDX team, we agreed to reuse the same app ID in the tracker across hosted SMK apps. They distinguish sites by the URL of the apps the tracker sends requests from, so the app ID does not need to be unique per hosted SMK app.
This replaces ESRI legacy basemap API with new ESRI vector basemap API. Legacy basemaps are replaced with new ArcGIS basemaps except for Streets, which is replaced by the OpenStreetMaps Standard map instead of the ArcGIS Streets map. The "esri-leaflet-vector" library is added. Basemaps are now added to a separate map pane having a lower z-index than map layers in order to prevent basemaps from covering layers. An ESRI API key, stored as a Github secret, is added to site configuration and used in basemap requests.
tlink-221 styling update
Add minZoom and maxZoom properties when initializing the leaflet map
tlink-246 Update to Overhead Structures data
tlink-246 update filtering for overhead signs
tlink-246 add heights to overhead directional sign identify
This reverts the change from StamenTonerLight to Streets, originally requested in #220 and updated to restore StamenTonerLight.
This PR has more merges than I wanted. I'll create a different PR that is based on the qa branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the change from StamenTonerLight to Streets, originally requested in #220 and updated to restore StamenTonerLight.