Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-606: Upload Capture Attachments #1388

Merged
merged 41 commits into from
Oct 7, 2024
Merged

Conversation

MacQSL
Copy link
Collaborator

@MacQSL MacQSL commented Oct 2, 2024

Links to Jira Tickets

SIMSBIOHUB-606

Description of Changes

  • User can now upload attachments during Capture creation
  • User can now remove and add attachments during Capture edit
  • User can download attachments in Create / Edit workflows
  • User can delete Capture (which deletes all associated attachments)

Testing Notes

  • Should be able to handle the above interactions

@MacQSL MacQSL added the Do Not Merge PR should not be merged label Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 44.15094% with 148 lines in your changes missing coverage. Please review.

Project coverage is 46.38%. Comparing base (9748a1d) to head (a0927f6).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...nimals/profile/captures/AnimalCaptureContainer.tsx 0.00% 21 Missing ⚠️
...ures/capture-form/components/AnimalCaptureForm.tsx 0.00% 19 Missing ⚠️
...ile/captures/capture-form/edit/EditCapturePage.tsx 0.00% 19 Missing ⚠️
...captures/capture-form/create/CreateCapturePage.tsx 0.00% 17 Missing ⚠️
app/src/hooks/useS3Download.tsx 0.00% 11 Missing ⚠️
...components/attachments/AttachmentTableDropzone.tsx 0.00% 10 Missing ⚠️
...ortality/mortality-form/edit/EditMortalityPage.tsx 0.00% 9 Missing ⚠️
app/src/hooks/api/useAnimalApi.ts 27.27% 8 Missing ⚠️
...rveyId}/attachments/{attachmentId}/getSignedUrl.ts 56.25% 6 Missing and 1 partial ⚠️
...ponents/data-grid/GenericGridColumnDefinitions.tsx 0.00% 7 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1388      +/-   ##
==========================================
+ Coverage   46.35%   46.38%   +0.03%     
==========================================
  Files         773      781       +8     
  Lines       20835    21060     +225     
  Branches     3147     3162      +15     
==========================================
+ Hits         9658     9769     +111     
- Misses      10596    10707     +111     
- Partials      581      584       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MacQSL MacQSL added Early Feedback Welcome PR is not finished, but early review feedback is welcomed and removed Do Not Merge PR should not be merged labels Oct 3, 2024
@MacQSL MacQSL added Ready For Review PR is ready for review and removed Early Feedback Welcome PR is not finished, but early review feedback is welcomed labels Oct 3, 2024
NickPhura
NickPhura previously approved these changes Oct 7, 2024
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Oct 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌵

@MacQSL MacQSL merged commit 90de834 into dev Oct 7, 2024
20 of 22 checks passed
@MacQSL MacQSL deleted the SIMSBIOHUB-606-S3-Capture branch October 7, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants