Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New way to get the tokens #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

New way to get the tokens #7

wants to merge 4 commits into from

Conversation

dpaz
Copy link
Contributor

@dpaz dpaz commented May 10, 2017 •
edited by creachadair
Loading

This PR solves #6. The approach that was taken, was to use the erl_scan library for all the code and then divide in expressions instead of dividing in expressions and then tokenize.

Changes

  • Tokenize now use the erl_scan:string method
  • SplitByDots, takes the Tokens and divide into sublists for the parser
  • Parse now only call parseExpr taking as input the list of lists given by SplitByDots
  • Added some unit test to check the right working of SplitByDots

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dpaz