feat: new landing page #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goldziher
requested changes
Jan 13, 2024
Goldziher
reviewed
Jan 14, 2024
| @@ -23,13 +23,13 @@ export function CodeSnippet({ | |||
| return ( | |||
There was a problem hiding this comment.
you have a conflict here. Check that your changes look OK inside the app.
Goldziher
reviewed
Jan 14, 2024
Goldziher
reviewed
Jan 14, 2024
Goldziher
reviewed
Jan 14, 2024
| }, | ||
| ]; | ||
|
|
||
| export function MarketingCodeSnippet() { |
There was a problem hiding this comment.
There is a lot of duplication and redundancy in this file. I suggest you refactor the code snippet used in the prompt config view to have a shared constants file for code examples and then reuse those used there.
| NavAuctionIconsList, | ||
| } from '@/components/static-site/nav-auction-icons'; | ||
|
|
||
| describe('NavAuctionIcons Tests', () => { |
There was a problem hiding this comment.
in flutter \ material design you call the icons at the end of the navbar auctions icons :) i thought its a common name
Goldziher
force-pushed
the
264-feat-improve-landing-page
branch
from
1c3a44e
to
bdbdf71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
pre-commit run --all-files) was executed and passedDescription
Close Issue(s)