Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add loading states with swr #140

Merged
merged 1 commit into from
Oct 28, 2023
Merged

feat: add loading states with swr #140

merged 1 commit into from
Oct 28, 2023

Conversation

Yatanvesh
Copy link
Contributor

No description provided.

Goldziher
Goldziher approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@Goldziher Goldziher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tests

@Yatanvesh
Copy link
Contributor Author

Looks good. Tests

oh no, this PR is gonna get a whole lot bigger

@Yatanvesh
Copy link
Contributor Author

but you may be right, i can close this PR easy

@Yatanvesh Yatanvesh merged commit e3edf70 into main Oct 28, 2023
7 of 8 checks passed
@Yatanvesh Yatanvesh deleted the swr branch October 28, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goldziher Goldziher Goldziher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yatanvesh @Goldziher