Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add applications list API, update nav rail UI #114

Merged
merged 2 commits into from
Oct 19, 2023
Merged

feat: add applications list API, update nav rail UI #114

merged 2 commits into from
Oct 19, 2023

Conversation

Yatanvesh
Copy link
Contributor

No description provided.

Copy link
Member

@Goldziher Goldziher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but light on the tests.

Please add -

  1. tests for the new API endpoint
  2. tests for the new store
  3. tests for all components

Fix:

  1. make sure to have data-testid attributes declared in all components and all parts of the components that need testing or might be interacted with such as buttons etc. (in the future we will add E2E tests)

@github-actions
Copy link

github-actions bot commented Oct 18, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 90.06% 2167 / 2406
🔵 Statements 90.06% 2167 / 2406
🔵 Functions 83.33% 95 / 114
🔵 Branches 90.94% 221 / 243
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
frontend/src/types.ts 100% 100% 100% 100%
frontend/src/api/applications-api.ts 100% 100% 100% 100%
frontend/src/app/projects/page.tsx 100% 100% 100% 100%
frontend/src/app/projects/[projectId]/application/[applicationId]/page.tsx 76.31% 66.66% 100% 76.31% 30-38
frontend/src/app/projects/[projectId]/dashboard/page.tsx 69.44% 66.66% 100% 69.44% 26-36
frontend/src/app/projects/create/page.tsx 100% 100% 100% 100%
frontend/src/components/app-layout.tsx 100% 100% 100% 100%
frontend/src/components/link-menu.tsx 94.82% 80% 100% 94.82% 52-54
frontend/src/components/nav-rail/nav-rail-list.tsx 82.4% 25% 100% 82.4% 44-62
frontend/src/constants/navigation.ts 100% 100% 100% 100%
frontend/src/stores/api-store.ts 100% 100% 100% 100%
frontend/src/stores/project-store.ts 97.72% 97.36% 100% 97.72% 53-54
frontend/src/utils/navigation.ts 100% 100% 100% 100%
Generated in workflow #33

@Yatanvesh
Copy link
Contributor Author

@Goldziher thanks, ive added tests for API endpoint, minimal as it is. will do the remaining tests

@Yatanvesh
Copy link
Contributor Author

finally 😭

@Goldziher Goldziher merged commit c666d90 into main Oct 19, 2023
4 checks passed
@Goldziher Goldziher deleted the 112 branch October 19, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants