-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add applications list API, update nav rail UI #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goldziher
reviewed
Oct 18, 2023
frontend/src/app/projects/[projectId]/application/[applicationId]/page.tsx
Outdated
Show resolved
Hide resolved
Goldziher
requested changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but light on the tests.
Please add -
- tests for the new API endpoint
- tests for the new store
- tests for all components
Fix:
- make sure to have
data-testid
attributes declared in all components and all parts of the components that need testing or might be interacted with such as buttons etc. (in the future we will add E2E tests)
frontend/src/app/projects/[projectId]/application/[applicationId]/page.tsx
Show resolved
Hide resolved
frontend/src/app/projects/[projectId]/application/[applicationId]/page.tsx
Outdated
Show resolved
Hide resolved
Coverage Report
File Coverage
|
@Goldziher thanks, ive added tests for API endpoint, minimal as it is. will do the remaining tests |
Goldziher
reviewed
Oct 18, 2023
Goldziher
reviewed
Oct 18, 2023
Yatanvesh
force-pushed
the
112
branch
2 times, most recently
from
October 19, 2023 15:44
8ee250b
to
593c39a
Compare
Goldziher
approved these changes
Oct 19, 2023
finally 😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.