chore: handle error in websocket

basemind-ai · Dec 7, 2023 · 6ba44c6 · 6ba44c6
1 parent 6fd67ff
commit 6ba44c6
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 14 deletions.
diff --git a/.github/workflows/deploy-frontend-preview.yaml b/.github/workflows/deploy-frontend-preview.yaml
@@ -25,7 +25,7 @@ jobs:
             - name: Setup Node
               uses: actions/setup-node@v4
               with:
-                  node-version: 21
+                  node-version: 16
             - name: Install Firebase CLI
               run: npm install -g firebase-tools
             - name: Install PNPM

diff --git a/.github/workflows/deploy-frontend.yaml b/.github/workflows/deploy-frontend.yaml
@@ -29,7 +29,7 @@ jobs:
             - name: Setup Node
               uses: actions/setup-node@v4
               with:
-                  node-version: 21
+                  node-version: 16
             - name: Install Firebase CLI
               run: npm install -g firebase-tools
             - name: Install PNPM

diff --git a/.idea/externalDependencies.xml b/.idea/externalDependencies.xml
diff --git a/services/dashboard-backend/internal/api/ws.go b/services/dashboard-backend/internal/api/ws.go
@@ -98,16 +98,25 @@ func CreatePayloadFromMessage(
 		FinishReason: msg.FinishReason,
 	}
 
+	isErr := *msg.FinishReason == "error"
+
+	if isErr {
+		log.Warn().Msg("stream ended due to an error. Check the api-gateway logs for more details")
+	}
+
 	if msg.PromptRequestRecordId != nil {
 		requestRecordID := exc.MustResult(db.StringToUUID(*msg.PromptRequestRecordId))
-		promptTestRecord := exc.MustResult(db.GetQueries().
+		promptTestRecord, createErr := db.GetQueries().
 			CreatePromptTestRecord(ctx, models.CreatePromptTestRecordParams{
 				PromptRequestRecordID: *requestRecordID,
 				Response:              builder.String(),
 				VariableValues:        serialization.SerializeJSON(data.TemplateVariables),
-			}))
-
-		payload.PromptTestRecordID = ptr.To(db.UUIDToString(&promptTestRecord.ID))
+			})
+		if createErr == nil {
+			payload.PromptTestRecordID = ptr.To(db.UUIDToString(&promptTestRecord.ID))
+		} else if !isErr {
+			log.Error().Err(createErr).Msg("failed to create prompt test record")
+		}
 	}
 
 	return serialization.SerializeJSON(payload)