fix [github] service tests (#9425)

* bring GH downloads/release errors into line * update GH lerna test example * update GH package.json test example * update GH pipenv test example * update GH search test assertion
badges · Aug 7, 2023 · d4faad1 · d4faad1
1 parent 5d71c1c
commit d4faad1
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 15 deletions.
diff --git a/services/github/github-downloads.service.js b/services/github/github-downloads.service.js
@@ -247,7 +247,7 @@ export default class GithubDownloads extends GithubAuthV3Service {
     }
 
     if (releases.length === 0) {
-      throw new NotFound({ prettyMessage: 'no releases' })
+      throw new NotFound({ prettyMessage: 'no releases found' })
     }
 
     const { downloads } = this.constructor.transform({

diff --git a/services/github/github-downloads.tester.js b/services/github/github-downloads.tester.js
@@ -19,11 +19,11 @@ t.create('Downloads all releases')
 
 t.create('Downloads all releases (no releases)')
   .get('/downloads/badges/shields/total.json')
-  .expectBadge({ label: 'downloads', message: 'no releases' })
+  .expectBadge({ label: 'downloads', message: 'no releases found' })
 
 t.create('Downloads-pre all releases (no releases)')
   .get('/downloads-pre/badges/shields/total.json')
-  .expectBadge({ label: 'downloads', message: 'no releases' })
+  .expectBadge({ label: 'downloads', message: 'no releases found' })
 
 t.create('Downloads all releases (repo not found)')
   .get('/downloads/badges/helmets/total.json')
@@ -154,7 +154,7 @@ t.create('downloads-pre for latest release')
 // https://github.com/badges/shields/issues/3786
 t.create('downloads-pre for latest release (no-releases)')
   .get('/downloads-pre/badges/shields/latest/total.json')
-  .expectBadge({ label: 'downloads', message: 'no releases' })
+  .expectBadge({ label: 'downloads', message: 'no releases found' })
 
 t.create('downloads for release without slash')
   .get('/downloads/atom/atom/v0.190.0/total.json')

diff --git a/services/github/github-lerna-json.tester.js b/services/github/github-lerna-json.tester.js
@@ -7,12 +7,10 @@ t.create('Lerna version').get('/facebook/jest.json').expectBadge({
   message: isSemver,
 })
 
-t.create('Lerna version (independent)')
-  .get('/jneander/jneander.json')
-  .expectBadge({
-    label: 'lerna',
-    message: 'independent',
-  })
+t.create('Lerna version (independent)').get('/imba/imba.json').expectBadge({
+  label: 'lerna',
+  message: 'independent',
+})
 
 t.create('Lerna version (branch)').get('/facebook/jest/main.json').expectBadge({
   label: 'lerna@main',

diff --git a/services/github/github-package-json.tester.js b/services/github/github-package-json.tester.js
@@ -93,9 +93,9 @@ t.create('Prod dependency version (monorepo)')
   })
 
 t.create('Scoped dependency')
-  .get('/dependency-version/badges/shields/dev/@babel/core.json')
+  .get('/dependency-version/badges/shields/dev/@docusaurus/core.json')
   .expectBadge({
-    label: '@babel/core',
+    label: '@docusaurus/core',
     message: semverRange,
   })
 

diff --git a/services/github/github-pipenv.tester.js b/services/github/github-pipenv.tester.js
@@ -82,8 +82,10 @@ t.create('Locked version of unknown dependency')
   })
 
 t.create('Locked version of VCS dependency')
-  .get('/locked/dependency-version/GSS-Cogs/databaker-docker/databaker.json')
+  .get(
+    '/locked/dependency-version/thorn-oss/perception/dev/videoalignment.json',
+  )
   .expectBadge({
-    label: 'databaker',
+    label: 'videoalignment',
     message: isShortSha,
   })
diff --git a/services/github/github-search.tester.js b/services/github/github-search.tester.js
@@ -8,4 +8,4 @@ t.create('hit counter')
 
 t.create('hit counter for nonexistent repo')
   .get('/badges/puppets/async%20handle.json')
-  .expectBadge({ label: 'counter', message: 'repo not found' })
+  .expectBadge({ label: 'async handle counter', message: '0' })