feat: 增加电视机雪花特效(close #256) #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
这个我得明天看一下，今天要赶论文 |
|
夸夸 |
mark9804
added a commit
that referenced
this pull request
Oct 17, 2024
说实话我确实想不到为什么一年半以前幻想 @ourandream 写了这个逻辑，现在想想大概是为了表示“没资源就是没做”。如果是这样的话之后可能加个 warn 或者 error 提示会好一些 但是如果你觉得“既然代码上线了那一定有它上线的原因”，那么也有不用改的做法。对于特效素材而言我们有维护一张资源表，在资源表里声明这个特效不需要额外资源就可以 691e956#diff-2d7f803b2538d68127a075424c2569c4be260a4c15b1ce795997a8d6d7a4348cR114-R115 这样进入原本的逻辑之后， 第二点是操作 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#256
补充电视机雪花特效。
因为是纯手搓，没有引入额外的图片资源，和原先的没找到相关资源就不执行特效的逻辑有冲突，稍微改了一下这个逻辑，希望不会影响其他特效。
测试效果：