-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: upgrade dependencies #1441
Conversation
@@ -8,6 +8,7 @@ package aws.sdk.kotlin.runtime.config.profile | |||
import aws.sdk.kotlin.runtime.InternalSdkApi | |||
|
|||
@InternalSdkApi | |||
@ConsistentCopyVisibility // Opt-in to future internal copy() generation https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-consistent-copy-visibility/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correctness: As shown in the API dump, this is a breaking change because it hides previously-public
copy
methods. What modules outside of aws-config use this class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its use is limited to aws-config. The other option is to apply @ExposedCopyVisibility
to keep the current behavior, do you prefer that?
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
Quality Gate passedIssues Measures |
A new generated diff is ready to view.
|
Affected ArtifactsChanged in size
|
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.