Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include kubernetes/cloud-provider-aws presubmit job to run only on main #404

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Jul 22, 2024

Description of changes:
Packages were made to run only on main in #402 but it missed the kubernetes/cloud-provider-aws project which is a dependency of packages. This PR includes that project in the list of packages presubmits jobs to run only on main.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Member

@abhay-krishna abhay-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sp1999
Copy link
Member Author

sp1999 commented Jul 22, 2024

/retest

@abhay-krishna
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 3ba60c4 into aws:main Jul 22, 2024
1 of 2 checks passed
@eks-distro-bot
Copy link
Collaborator

@sp1999: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key cloud-provider-aws-1-26-presubmit.yaml using file jobs/aws/eks-anywhere-build-tooling/cloud-provider-aws-1-26-presubmit.yaml
  • key cloud-provider-aws-1-27-presubmit.yaml using file jobs/aws/eks-anywhere-build-tooling/cloud-provider-aws-1-27-presubmit.yaml
  • key cloud-provider-aws-1-28-presubmit.yaml using file jobs/aws/eks-anywhere-build-tooling/cloud-provider-aws-1-28-presubmit.yaml
  • key cloud-provider-aws-1-29-presubmit.yaml using file jobs/aws/eks-anywhere-build-tooling/cloud-provider-aws-1-29-presubmit.yaml
  • key cloud-provider-aws-1-30-presubmit.yaml using file jobs/aws/eks-anywhere-build-tooling/cloud-provider-aws-1-30-presubmit.yaml

In response to this:

Description of changes:
Packages were made to run only on main in #402 but it missed the kubernetes/cloud-provider-aws project which is a dependency of packages. This PR includes that project in the list of packages presubmits jobs to run only on main.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants