Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove error STRING_VALUE cannot be converted to an Integer (#12… #13157

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

marcomilon
Copy link

Description of changes

Issue:

When calling the AdminQueries lambda function with the limit parameter, it returns a 500 error because the limit parameter cannot be converted to an integer.

Fix:

Update the code used to generate the AdminQueries lambda function by parsing the limit parameter to return an integer.

Change in this PR:

Added parseInt to packages/amplify-category-auth/resources/adminAuth/admin-auth-cognitoActions.js when using the Limit parameter.

Issue #, if available

Description of how you validated changes

I created a sample app and tested the following paths on the AdminQueries lambda function using the limit parameter:

  • listUsers
  • listGroups
  • listGroupsForUser
  • listUsersInGroup

They work as expected after applying my fix return the correct response with http code 200.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@marcomilon marcomilon requested a review from a team as a code owner August 27, 2023 00:00
@marcomilon
Copy link
Author

Hello,

Will this PR ever be merged?

@fabianf92
Copy link

Hi, any updates on this PR? I am facing the issue and can't use the limit parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants