Fix Puppeteer tests

auth0 · Sep 15, 2023 · 94a77f0 · 94a77f0
1 parent 0061b24
commit 94a77f0
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 30 deletions.
diff --git a/end-to-end/access-an-api.js b/end-to-end/access-an-api.js
@@ -32,11 +32,11 @@ describe('access an api', async () => {
   });
 
   it('should get an access token and access an api', async () => {
-    const args = puppeteer.defaultArgs();
-    args.set('--no-sandbox');
-    args.set('--disable-setuid-sandbox');
-
-    const browser = await puppeteer.launch(args);
+    const browser = await puppeteer.launch({
+      args: puppeteer
+        .defaultArgs()
+        .concat(['--no-sandbox', '--disable-setuid-sandbox']),
+    });
     const page = await browser.newPage();
 
     const clock = sinon.useFakeTimers({

diff --git a/end-to-end/attempt-silent-login.test.js b/end-to-end/attempt-silent-login.test.js
@@ -26,11 +26,11 @@ describe('attempt silent login', async () => {
   });
 
   it('should attempt silent login and swallow failures', async () => {
-    const args = puppeteer.defaultArgs();
-    args.set('--no-sandbox');
-    args.set('--disable-setuid-sandbox');
-
-    const browser = await puppeteer.launch(args);
+    const browser = await puppeteer.launch({
+      args: puppeteer
+        .defaultArgs()
+        .concat(['--no-sandbox', '--disable-setuid-sandbox']),
+    });
     const page = await browser.newPage();
     await goto(baseUrl, page);
     await page.waitForNavigation();
@@ -45,11 +45,11 @@ describe('attempt silent login', async () => {
   });
 
   it('should login silently if there is an active session on the IDP', async () => {
-    const args = puppeteer.defaultArgs();
-    args.set('--no-sandbox');
-    args.set('--disable-setuid-sandbox');
-
-    const browser = await puppeteer.launch(args);
+    const browser = await puppeteer.launch({
+      args: puppeteer
+        .defaultArgs()
+        .concat(['--no-sandbox', '--disable-setuid-sandbox']),
+    });
     const page = await browser.newPage();
     await goto(`${baseUrl}/login`, page);
     assert.match(

diff --git a/end-to-end/basic.test.js b/end-to-end/basic.test.js
@@ -28,11 +28,11 @@ describe('basic login and logout', async () => {
   });
 
   it('should login and logout with default configuration', async () => {
-    const args = puppeteer.defaultArgs();
-    args.set('--no-sandbox');
-    args.set('--disable-setuid-sandbox');
-
-    const browser = await puppeteer.launch(args);
+    const browser = await puppeteer.launch({
+      args: puppeteer
+        .defaultArgs()
+        .concat(['--no-sandbox', '--disable-setuid-sandbox']),
+    });
     const page = await browser.newPage();
     await goto(baseUrl, page);
     assert.match(

diff --git a/end-to-end/private-key-jwt.test.js b/end-to-end/private-key-jwt.test.js
@@ -27,11 +27,11 @@ describe('private key jwt', async () => {
   });
 
   it('should login with private key jwt client auth method', async () => {
-    const args = puppeteer.defaultArgs();
-    args.set('--no-sandbox');
-    args.set('--disable-setuid-sandbox');
-
-    const browser = await puppeteer.launch(args);
+    const browser = await puppeteer.launch({
+      args: puppeteer
+        .defaultArgs()
+        .concat(['--no-sandbox', '--disable-setuid-sandbox']),
+    });
     const page = await browser.newPage();
     await goto(baseUrl, page);
     assert.match(page.url(), /http:\/\/localhost:3000/);

diff --git a/end-to-end/userinfo.test.js b/end-to-end/userinfo.test.js
@@ -26,11 +26,11 @@ describe('fetch userinfo', async () => {
   });
 
   it('should login with hybrid flow and fetch userinfo', async () => {
-    const args = puppeteer.defaultArgs();
-    args.set('--no-sandbox');
-    args.set('--disable-setuid-sandbox');
-
-    const browser = await puppeteer.launch(args);
+    const browser = await puppeteer.launch({
+      args: puppeteer
+        .defaultArgs()
+        .concat(['--no-sandbox', '--disable-setuid-sandbox']),
+    });
     const page = await browser.newPage();
     await goto(baseUrl, page);
     assert.match(