Show non-ready custom domains (#781)

Displaying non-ready custom domains Co-authored-by: Will Vedder <will.vedder@okta.com>
auth0 · Aug 1, 2023 · 411bcda · 411bcda
1 parent 4d5afa9
commit 411bcda
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 13 deletions.
diff --git a/internal/cli/custom_domains.go b/internal/cli/custom_domains.go
@@ -464,10 +464,6 @@ func (c *cli) customDomainsPickerOptions(ctx context.Context) (pickerOptions, er
 	}
 
 	for _, d := range domains {
-		if d.GetStatus() != "ready" {
-			continue
-		}
-
 		value := d.GetID()
 		label := fmt.Sprintf("%s %s", d.GetDomain(), ansi.Faint("("+value+")"))
 		opts = append(opts, pickerOption{value: value, label: label})

diff --git a/internal/cli/custom_domains_test.go b/internal/cli/custom_domains_test.go
@@ -124,23 +124,20 @@ func TestCustomDomainsPickerOptions(t *testing.T) {
 				{
 					ID:     auth0.String("some-id-1"),
 					Domain: auth0.String("some-domain-1"),
-					Status: auth0.String("foo"),
+					Status: auth0.String("pending_verification"),
 				},
 				{
 					ID:     auth0.String("some-id-2"),
 					Domain: auth0.String("some-domain-2"),
 					Status: auth0.String("ready"),
 				},
-				{
-					ID:     auth0.String("some-id-3"),
-					Domain: auth0.String("some-domain-3"),
-					Status: auth0.String("bar"),
-				},
 			},
 			assertOutput: func(t testing.TB, options pickerOptions) {
-				assert.Len(t, options, 1)
-				assert.Equal(t, "some-domain-2 (some-id-2)", options[0].label)
-				assert.Equal(t, "some-id-2", options[0].value)
+				assert.Len(t, options, 2)
+				assert.Equal(t, "some-domain-1 (some-id-1)", options[0].label)
+				assert.Equal(t, "some-id-1", options[0].value)
+				assert.Equal(t, "some-domain-2 (some-id-2)", options[1].label)
+				assert.Equal(t, "some-id-2", options[1].value)
 			},
 			assertError: func(t testing.TB, err error) {
 				t.Fail()