Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for an authorize URL override #854

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

erichoracek
Copy link
Contributor

@erichoracek erichoracek commented May 29, 2024

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

Adds support for overriding the authorize URL, to match the behavior of the Android SDK.

Adds a authorizeURL(…) method on WebAuth:

webAuth
  .authorizeURL(URL(string: "https://example.com/authorize")!)

📎 References

Android version of this change: auth0/Auth0.Android#622

🎯 Testing

Added unit tests to verify that when an override authorize URL is specified, it is respected.

@erichoracek erichoracek requested a review from a team as a code owner May 29, 2024 05:04
@desusai7
Copy link
Contributor

Hi @erichoracek,

Thank you for raising this, we will check this out

@desusai7
Copy link
Contributor

desusai7 commented Jun 6, 2024

Hi @erichoracek,

We are discussing this internally from a security standpoint and will keep you posted on any updates.

@desusai7 desusai7 self-requested a review June 6, 2024 06:23
@desusai7 desusai7 merged commit f5005cb into auth0:master Jun 19, 2024
9 checks passed
@desusai7 desusai7 mentioned this pull request Jun 19, 2024
@desusai7
Copy link
Contributor

@erichoracek, this has been released as part of version 2.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants