Wait for admin dropdown

CHANGELOG.md

@@ -24,7 +24,13 @@ Adding a requirement of a major version of a dependency is breaking a contract.
 Dropping a requirement of a major version of a dependency is a new contract.
 
 ## [Unreleased]
-[Unreleased]: https://github.com/atlassian/jira-actions/compare/release-3.27.0...master
+[Unreleased]: https://github.com/atlassian/jira-actions/compare/release-3.28.0...master
+
+### Fixed
+- Avoid premature navigation when clicking the administration cog.
+
+## [3.28.0] - 2024-06-17
+[3.28.0]: https://github.com/atlassian/jira-actions/compare/release-3.27.0...release-3.28.0
 
 ### Added
 - Split `SetUpAction` into `DisableRichTextEditor` and `HideHealthNotifications`.

src/main/kotlin/com/atlassian/performance/tools/jiraactions/api/WebJira.kt

@@ -3,7 +3,9 @@ package com.atlassian.performance.tools.jiraactions.api
 import com.atlassian.performance.tools.jiraactions.administration.JiraAdministrationMenu
 import com.atlassian.performance.tools.jiraactions.api.page.*
 import org.openqa.selenium.By
+import org.openqa.selenium.JavascriptExecutor
 import org.openqa.selenium.WebDriver
+import org.openqa.selenium.support.ui.ExpectedCondition
 import java.net.URI
 import java.net.URLEncoder
 
@@ -108,8 +110,26 @@ data class WebJira(
 
     internal fun administrate(): JiraAdministrationMenu {
         NotificationPopUps(driver).waitUntilAuiFlagsAreGone()
-        driver.findElement(By.id("admin_menu")).click()
+        val adminCog = By.id("admin_menu")
+        waitForAdminCog()
+        driver.findElement(adminCog).click()
         val menu = driver.findElement(By.id("system-admin-menu-content"))
         return JiraAdministrationMenu(driver, menu)
     }
+
+    /**
+     * If we click on the administration cog too fast
+     * we would navigate to `plugins/servlet/applications/versions-licenses`
+     * and be asked for websudo password [AdminAccess].
+     */
+    private fun waitForAdminCog() = waitForDomComplete()
+
+    private fun waitForDomComplete() {
+        val js = driver as JavascriptExecutor
+        val domComplete = ExpectedCondition {
+            val state = js.executeScript("return document.readyState") as String?
+            state == "complete"
+        }
+        driver.wait(domComplete)
+    }
 }

src/main/kotlin/com/atlassian/performance/tools/jiraactions/api/action/DisableRichTextEditor.kt

@@ -4,6 +4,9 @@ import com.atlassian.performance.tools.jiraactions.api.DISABLE_RICH_TEXT_EDITOR
 import com.atlassian.performance.tools.jiraactions.api.WebJira
 import com.atlassian.performance.tools.jiraactions.api.measure.ActionMeter
 
+/**
+ * @since 3.28.0
+ */
 class DisableRichTextEditor(
     private val jira: WebJira,
     private val meter: ActionMeter

src/main/kotlin/com/atlassian/performance/tools/jiraactions/api/action/HideHealthNotifications.kt

@@ -4,6 +4,9 @@ import com.atlassian.performance.tools.jiraactions.api.HIDE_HEALTH_NOTIFICATIONS
 import com.atlassian.performance.tools.jiraactions.api.WebJira
 import com.atlassian.performance.tools.jiraactions.api.measure.ActionMeter
 
+/**
+ * @since 3.28.0
+ */
 class HideHealthNotifications(
     private val jira: WebJira,
     private val meter: ActionMeter