JPERF-1435: remove JS header parsing #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For every resource (navigation, XHR, JS, CSS, image), it would send a new HTTP request to parse headers. The resource URI was not taken into account in the synthetic request, so it could not infer original HTTP headers. Especially since the new request can have different response headers than the original requests. And even if they had the same, then it means we assume sticky session. So we might read node id once just as well. Supposedly, the synthetic request was being read from a cache, but apparently it's still too much overhead. We'll have to read the node id from `Server-Timing` header, which is automatically captured by the browser and it's the same way we obtain the response thread id.
pczuj
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For every resource (navigation, XHR, JS, CSS, image), it would send a
new HTTP request to parse headers.
The resource URI was not taken into account in the synthetic request,
so it could not infer original HTTP headers. Especially since the new
request can have different response headers than the original requests.
And even if they had the same, then it means we assume sticky session.
So we might read node id once just as well.
Supposedly, the synthetic request was being read from a cache,
but apparently it's still too much overhead.
We'll have to read the node id from
Server-Timingheader,which is automatically captured by the browser
and it's the same way we obtain the response thread id.