JPERF-1401: Reuse JsonProvider
#159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Avoid scanning the classpath on every JSON value creation. Repeat the same perf fix as in atlassian/report#97 I apologize for not adding a test for the APIs in this lib. Our team is running out of time. Dear future reader, if the libs get development time again, I would: * import a big action metrics file with lots of drilldown JSONs * run parsing and serialization in parallel with concurrency = 4
dagguh
force-pushed
the
issue/JPERF-1401-reuse-json-provider
branch
from
2245d1d
to
9da6373
Compare
mgrzaslewicz
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid scanning the classpath on every JSON value creation.
Repeat the same perf fix as in atlassian/report#97 I apologize for not adding a test for the APIs in this lib. Our team is running out of time.
Dear future reader, if the libs get development time again, I would: