Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding framerate control for Vimba v6 #121

Merged
merged 3 commits into from
May 29, 2023

Conversation

MikoMikarro
Copy link

No description provided.

@icolwell-as
Copy link
Member

Thanks @MikoMikarro for the PR! Can you provide some more context and details in the PR description?
For example:

  • Why is this new parameter needed?
  • What problem did you run into that this is solving?
  • What camera hardware are you using?

@MikoMikarro
Copy link
Author

MikoMikarro commented May 25, 2023

Hi, we added the new name for the frame parameter that was added with the last firmware, this fixes some of the problems related to issue #86 . Without this change in the parameter name, we couldn't change the camera's frame rate. I've also left uncommented the last name so it should work without any problem in the previous and current firmware.

I've also added the parameter that allows to use free run or fix the framerate.

Our team is using the G-201 camera: https://www.alliedvision.com/en/camera-selector/detail/manta/g-201/

Copy link
Member

@icolwell-as icolwell-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the details! these change make sense to me, just a small nitpick on the formatting.

Thanks again for taking the time to submit a PR!

cfg/AvtVimbaCamera.cfg Outdated Show resolved Hide resolved
changed white spacing to align all parameters
icolwell-as
icolwell-as previously approved these changes May 26, 2023
launch/Mako_G-319.launch Outdated Show resolved Hide resolved
Copy link

@shan-as shan-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not tested on a camera

@icolwell-as icolwell-as merged commit 095642d into astuff:ros1_master May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants