-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update citation details in docs and add CITATION.cff file #236
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
=======================================
Coverage 93.28% 93.28%
=======================================
Files 29 29
Lines 3170 3170
=======================================
Hits 2957 2957
Misses 213 213 ☔ View full report in Codecov by Sentry. |
family-names: Price | ||
affiliation: University College London | ||
- given-names: Jason | ||
orcid: 'https://orcid.org/0000-0002-5852-8890' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not actively using this so no need to cite. If anything would be better to cite my website (www.jasonmcewen.org)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added your website here and in preferred citation (and also Matt's). Unless you have a strong preference of not including ORCiD I would say better to include it as it helps with having research outputs automatically indexed - for example if we start having releases archived on Zenodo using the Zenodo GitHub integration then your ORCiD will be automatically pulled from the CITATION.cff
file and added to the metadata for the archive on Zenodo. As your ORCiD is linked to your UCL profile / entry on RPS this means any archive on Zenodo can then also be automatically synced to your RPS profile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, fine to keep the ORCiD then.
Thanks a lot @matt-graham . Great to have this set up. Good to specify the paper as the preferred citation. In terms of code authors, we should certainly extend this beyond @CosmoMatt and I. We should certainly include you, @ASKabalan and others that have made core contributions. We could also extend this to "all-contributors". What do you think best? |
@matt-graham While we're updating citation details, I just saw in the readme, in a couple of places we have:
This should also be updated to a hyperlink like in the opening sentence. Could you correct that while you're at it? |
These in text citations are now updated to |
I would say either sticking to just you and @CosmoMatt or extending to all contributors (or possibly those having made commits to If we decide to include only a subset of contributors, my experience is it is difficult to decide how to do this consistently / fairly and creates issues with both having to make a manual decision every time someone new contributes whether to include as an author and also means we need to remember to keep |
@matt-graham imo we should just include all contributors here. It is the most straightforward solution and highlights everyone's contributions to the code. But I'm ultimately happy with whatever people prefer! |
Yep agreed, let's include all-contributors in the citation authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have approved this so you can merge at your convenience.
We can either set up the auto-population of the citation file from all contributors now or consider it in as a separate PR.
Resolves #225 and resolves #217
Updates the citation BibTeX details in various places in documentation to reflected published and accepted version of JCP article and also adds a
CITATION.cff
file with this citation data.The default behaviour of
CITATION.cff
is to list the citation metadata for the software itself however there is apreferred-citation
field for adding details of another artefact that should be cited in preference first. I've added JCP article details to this field and some basic metadata for software to main fields. For now I've just listed @CosmoMatt and @jasonmcewen as authors on the software. An alternative would be to list all contributors for example.