-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loss value metric based on optimal performance definition #66
Open
jteijema
wants to merge
5
commits into
asreview:main
Choose a base branch
from
jteijema:loss-metric
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ | |
from asreviewcontrib.insights.algorithms import _erf_values | ||
from asreviewcontrib.insights.algorithms import _fn_values | ||
from asreviewcontrib.insights.algorithms import _fp_values | ||
from asreviewcontrib.insights.algorithms import _loss_value | ||
from asreviewcontrib.insights.algorithms import _recall_values | ||
from asreviewcontrib.insights.algorithms import _tn_values | ||
from asreviewcontrib.insights.algorithms import _tp_values | ||
|
@@ -169,6 +170,24 @@ def _tnr(labels, intercept, x_absolute=False): | |
|
||
return _slice_metric(x, y, intercept) | ||
|
||
def loss(state_obj, priors=False): | ||
""" | ||
Computes a loss value that represents how far the recall curve is from | ||
perfect recall. | ||
|
||
The function calculates a value based on the area over the recall curve and | ||
under the perfect recall (i.e., an impossible area for recall values). | ||
|
||
Returns: | ||
float: The loss value representing the distance from perfect recall. | ||
""" | ||
labels = _pad_simulation_labels(state_obj, priors=priors) | ||
|
||
return _loss(labels) | ||
|
||
def _loss(labels): | ||
return _loss_value(labels) | ||
|
||
Comment on lines
+188
to
+190
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the added value? |
||
|
||
def get_metrics( | ||
state_obj, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this not something like y*np.diff(x)?
In that case, we don't need the dependency (which is installed via asreview, but yeah).