Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sample Datatool #41

Merged
merged 14 commits into from
Apr 8, 2024
Merged

Add Sample Datatool #41

merged 14 commits into from
Apr 8, 2024

Conversation

laurens88
Copy link
Contributor

Introducing a new addition for datatools, sample. Used for sampling k old, k new, and k random records from a dataset to detect concept drift.

If you could test the code for bugs and look at my section in the readme file that would be of great help!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@PeterLombaers
Copy link
Member

Seems to work well, and this is a nice addition!

@PeterLombaers
Copy link
Member

PeterLombaers commented Apr 4, 2024

Two more things:

  • Could you apply formatting? (see the ASReview development instructions, basically install ruff and run ruff format . from the repo root)
  • A test would be nice. Just something that takes a test dataset, runs your sample tool and check that the output is in the format that you expect. You can see some examples of tests in the tests directory. If you need any help with this, just let me know!

@PeterLombaers
Copy link
Member

Thanks for implementing this and ironing out the last details!

@PeterLombaers PeterLombaers changed the title New sample datatool Add Sample Datatool Apr 8, 2024
@PeterLombaers PeterLombaers merged commit d71440c into asreview:main Apr 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants