Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade for Swift 5.0 #38

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Thisura98
Copy link

Modified core files for compatibility with Swift 5.0. Bumped the version from 2.0.0 to 2.0.1. Modified Readme and .podspec files to match the upgrade. All changes have been made in the development branch only.

Copy link

@ykws ykws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great!

However it's supported iOS9 or later on latest Xcode, so needs to update deployment_target as well.
Also, needs to update the following contents in the README.

  • Requirements
    • iOS 9.0+
    • Xcode 13.2.1

Perhaps a minimal update of Xcode might be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants