fix deprecated header file in humble and jazzy (#10)

* fix deprecated header file in humble and jazzy * fix the memory leak bug! no more random crash of rviz2
arplaboratory · Jun 24, 2024 · a012272 · a012272
1 parent ef5893e
commit a012272
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 1 deletion.
diff --git a/waypoint_navigation_plugin/cmake/ROS2.cmake b/waypoint_navigation_plugin/cmake/ROS2.cmake
@@ -21,6 +21,7 @@ find_package(rviz_common REQUIRED)
 find_package(rviz_default_plugins REQUIRED)
 find_package(rviz_rendering REQUIRED)
 find_package(rosbag2_cpp REQUIRED)
+find_package(rosbag2_storage REQUIRED)
 find_package(mav_manager_srv REQUIRED)
 find_package(rviz_ogre_vendor REQUIRED)
 find_package(std_srvs REQUIRED)

diff --git a/waypoint_navigation_plugin/package.xml b/waypoint_navigation_plugin/package.xml
@@ -24,6 +24,7 @@
   <depend condition="$ROS_VERSION == 2">rviz_rendering</depend>
   <depend condition="$ROS_VERSION == 2">sensor_msgs</depend>
   <depend condition="$ROS_VERSION == 2">rosbag2_cpp</depend>
+  <depend condition="$ROS_VERSION == 2">rosbag2_storage</depend>
   <depend condition="$ROS_VERSION == 2">mav_manager_srv</depend>
 
   <build_depend condition="$ROS_VERSION == 2">qtbase5-dev</build_depend>

diff --git a/waypoint_navigation_plugin/src/waypoint_nav_frame_ros2.hpp b/waypoint_navigation_plugin/src/waypoint_nav_frame_ros2.hpp
@@ -65,7 +65,7 @@
 #include <rosbag2_cpp/writer.hpp>
 #include <rosbag2_cpp/reader.hpp>
 #include <rclcpp/serialization.hpp>
-#include <rosbag2_cpp/storage_options.hpp>
+#include <rosbag2_storage/storage_options.hpp>
 #include <OgrePrerequisites.h>
 
 typedef struct {

diff --git a/waypoint_navigation_plugin/src/waypoint_nav_tool_ros2.cpp b/waypoint_navigation_plugin/src/waypoint_nav_tool_ros2.cpp
@@ -72,6 +72,7 @@ WaypointNavTool::~WaypointNavTool()
 
   delete frame_;
   delete frame_dock_;
+  delete moving_flag_node_;
 }
 
 void WaypointNavTool::onInitialize()