Fix broken application name override

Fixes #17

modules/applications/default.nix

@@ -86,7 +86,7 @@ in {
     };
     namespace = mkOption {
       type = types.str;
-      default = name;
+      default = config.name;
       description = "Namespace to deploy application into (defaults to name).";
     };
     createNamespace = mkOption {
@@ -255,7 +255,7 @@ in {
     output = {
       path = mkOption {
         type = types.str;
-        default = name;
+        default = config.name;
         description = ''
           Name of the folder that contains all rendered resources for the application. Relative to the root of the repository.
         '';

modules/nixidy.nix

@@ -189,7 +189,7 @@ in {
         lib.attrsets.mapAttrs (
           n: app: {
             metadata = {
-              name = n;
+              inherit (app) name;
               annotations =
                 if app.annotations != {}
                 then app.annotations

tests/default.nix

@@ -8,6 +8,7 @@
       ./compare-options.nix
       ./create-namespace.nix
       ./yamls.nix
+      ./override-name.nix
       ./helm/no-values.nix
       ./helm/with-values.nix
       ./helm/transformer.nix

tests/override-name.nix

@@ -0,0 +1,37 @@
+{config, ...}: let
+  apps = config.applications;
+in {
+  applications.test1 = {
+    name = "test1override";
+  };
+
+  test = {
+    name = "application name override";
+    description = "Check that application name override works as expected.";
+    assertions = [
+      {
+        description = "Output path should use override name.";
+
+        expression = apps.test1.output.path;
+
+        expected = "test1override";
+      }
+
+      {
+        description = "Namespace without override should use override name.";
+
+        expression = apps.test1.namespace;
+
+        expected = "test1override";
+      }
+
+      {
+        description = "Generated Argo CD applicaiton should use override name.";
+
+        expression = apps.apps.resources.applications.test1.metadata.name;
+
+        expected = "test1override";
+      }
+    ];
+  };
+}