atlasexec/migrate-lint: added support for --web #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8m
reviewed
Sep 26, 2023
dorav
force-pushed
the
add_base_and_web_lint_parameters
branch
from
b149f17
to
c28666c
Compare
dorav
changed the title
dorav
force-pushed
the
add_base_and_web_lint_parameters
branch
from
c28666c
to
a4a11cf
Compare
a8m
reviewed
Sep 26, 2023
a8m
reviewed
Sep 26, 2023
a8m
reviewed
Sep 26, 2023
a8m
reviewed
Sep 26, 2023
a8m
reviewed
Sep 26, 2023
a8m
reviewed
Sep 26, 2023
a8m
reviewed
Sep 26, 2023
a8m
reviewed
Sep 26, 2023
a8m
reviewed
Sep 26, 2023
a8m
reviewed
Sep 26, 2023
a8m
reviewed
Sep 26, 2023
a8m
reviewed
Sep 26, 2023
a8m
reviewed
Sep 26, 2023
added 9 commits
September 27, 2023 09:03
added 2 commits
September 27, 2023 09:07
a8m
reviewed
Sep 27, 2023
atlasexec/atlas_test.go
Outdated
Comment on lines
154
to
172
| tmpl := `atlas { | ||
| cloud { | ||
| token = "{{ .Token }}" | ||
| {{- if .URL }} | ||
| url = "{{ .URL }}" | ||
| {{- end }} | ||
| } | ||
| } | ||
| env "test" {}` | ||
| config := template.Must(template.New("atlashcl").Parse(tmpl)) | ||
| templateParams := struct { | ||
| URL string | ||
| Token string | ||
| }{ | ||
| URL: srv.URL, | ||
| Token: token, | ||
| } | ||
| var buf bytes.Buffer | ||
| require.NoError(t, config.Execute(&buf, templateParams)) |
There was a problem hiding this comment.
just use fmt.Sprintf or inject the variable instead with var.url
a8m
reviewed
Sep 27, 2023
atlasexec/atlas_test.go
Outdated
| var query graphQLQuery | ||
| require.NoError(t, json.NewDecoder(r.Body).Decode(&query)) | ||
| if strings.Contains(query.Query, "mutation reportMigrationLint") { | ||
| _, _ = fmt.Fprint(w, `{ "data": { "reportMigrationLint": { "url": "https://migration-lint-report-url" } } }`) |
There was a problem hiding this comment.
Suggested change
| _, _ = fmt.Fprint(w, `{ "data": { "reportMigrationLint": { "url": "https://migration-lint-report-url" } } }`) | |
| _, err := fmt.Fprint(w, `{ "data": { "reportMigrationLint": { "url": "https://migration-lint-report-url" } } }`) | |
| require.NoError(t, err) |
a8m
reviewed
Sep 27, 2023
|
@a8m Yalla, let's merge |
a8m
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.