atlasexec: always quote the directive input (#106)

ariga · Oct 14, 2024 · 6e1a482 · 6e1a482
1 parent 99a5cdb
commit 6e1a482
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/atlasexec/atlas_schema.go b/atlasexec/atlas_schema.go
@@ -4,6 +4,7 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
+	"strconv"
 	"time"
 
 	"ariga.io/atlas/sql/migrate"
@@ -420,7 +421,7 @@ func (c *Client) SchemaPlan(ctx context.Context, params *SchemaPlanParams) (*Sch
 		args = append(args, "--auto-approve")
 	}
 	for _, d := range params.Directives {
-		args = append(args, "--directive", d)
+		args = append(args, "--directive", strconv.Quote(d))
 	}
 	// NOTE: This command only support one result.
 	return firstResult(jsonDecode[SchemaPlan](c.runCommand(ctx, args)))

diff --git a/atlasexec/atlas_schema_test.go b/atlasexec/atlas_schema_test.go
@@ -254,9 +254,9 @@ func TestSchema_Plan(t *testing.T) {
 			params: &atlasexec.SchemaPlanParams{
 				From:       []string{"1", "2"},
 				To:         []string{"2", "3"},
-				Directives: []string{"atlas:nolint", "\"atlas:txmode none\""},
+				Directives: []string{"atlas:nolint", "atlas:txmode none"},
 			},
-			args: `schema plan --format {{ json . }} --from 1,2 --to 2,3 --auto-approve --directive atlas:nolint --directive "atlas:txmode none"`,
+			args: `schema plan --format {{ json . }} --from 1,2 --to 2,3 --auto-approve --directive "atlas:nolint" --directive "atlas:txmode none"`,
 		},
 		{
 			name: "with config",