fix: panic to write in close channel #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
reviewed
Sep 27, 2024
pkg/crawler/crawler.go
Outdated
| @@ -58,8 +57,12 @@ func NewCrawler(opt Option) Crawler { | |||
| } | |||
| } | |||
| client.ErrorHandler = func(resp *http.Response, err error, numTries int) (*http.Response, error) { | |||
| logger := slog.With(slog.String("url", resp.Request.URL.String()), slog.Int("status_code", resp.StatusCode), | |||
| slog.Int("num_tries", numTries)) | |||
| logger := &slog.Logger{} | |||
There was a problem hiding this comment.
If we create a new logger, the default setting is not respected.
trivy-java-db/cmd/trivy-java-db/main.go
Line 65 in 577c6a3
Suggested change
| logger := &slog.Logger{} | |
| logger := slog.Default() |
There was a problem hiding this comment.
nice catch! Updated in 111f5bb
knqyf263
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes:
selectinstead ofonceforerrCh(see fix(crawler):Visitfunction should write error inerrChonce #36 (comment))defaultinselectfor write intourlCh(see fix(crawler):Visitfunction should write error inerrChonce #36 (comment)).