Fix: Graph deleted before aptly exits #1214
Open
+114
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1213
Requirements
All new code should be covered with tests, documentation should be updated. CI should pass.
Description of the Change
The temporary output file is now only deleted after copying it to the output location.
We no longer wait 1s for the open command, but exit immediately, since the process will continue running even after aptly exits.
Why this change is important?
Because the assumption was made that any application that opened the image would continue displaying it, even if the image was removed right after, which isn't true for the Gnome Image Viewer.
Checklist
AUTHORS