Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve recall with section-restricted search #9

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

barjin
Copy link
Collaborator

@barjin barjin commented Jul 29, 2024

By first retrieving only the current section results (and then everything else but the current section), we improve recall in the first search stage - so that after reranking, the results definitely contain the current section records (if those exist).

closes apify/apify-docs#1109

@barjin barjin added the adhoc Ad-hoc unplanned task added during the sprint. label Jul 29, 2024
@barjin barjin added this to the 94th sprint - Tooling team milestone Jul 29, 2024
@barjin barjin requested review from janbuchar and B4nan July 29, 2024 11:09
@barjin barjin self-assigned this Jul 29, 2024
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Jul 29, 2024
src/components/ApifySearch.tsx Outdated Show resolved Hide resolved
src/components/ApifySearch.tsx Outdated Show resolved Hide resolved
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll trust you on this one, hard to test before merging

@barjin
Copy link
Collaborator Author

barjin commented Jul 30, 2024

hard to test

Automatically, yes - for manual testing I added a sample web app to the repo yesterday. Thanks to HMR, this simplifies the development a great bit.

Thanks for the faith though :) IMO this should be quite safe

@barjin barjin merged commit 40993ef into master Jul 30, 2024
2 checks passed
@barjin barjin deleted the fix/aided-reranking-recall branch July 30, 2024 08:15
B4nan pushed a commit to apify/apify-docs that referenced this pull request Aug 12, 2024
Bumps the `@apify/docs-search-modal` version to include the changes from
apify/docs-search-modal#9 .

Completely closes #1109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs search does not search all content
3 participants