WICKET-7121: Make it possible to disable the noisy logs by RequestCycle #928
Conversation
| @@ -52,7 +52,8 @@ private static String detail(Component component, | |||
| StringBuilder detail = new StringBuilder("Component: ").append(component.toString(false)); | |||
| if (behavior != null) | |||
| { | |||
| detail.append(" Behavior: ").append(behavior.toString()); | |||
| detail.append(" Behavior: ").append(behavior); | |||
| detail.append(" Path: ").append(component.getPath()); | |||
There was a problem hiding this comment.
ah yes, will fix that
| logExtra.warn("********************************"); | ||
| logExtra.warn("Handling the following exception", e); | ||
| logExtra.warn("********************************"); | ||
| logExtra.warn("###***===--- Handling the following exception ---===***###", e); |
There was a problem hiding this comment.
What's the problem with the asterisks in Kafka aggregators?
There was a problem hiding this comment.
Its the lines with **************************, they spam the log with no informational value
There was a problem hiding this comment.
Let's remove the special pre/suffix for good! I can foresee the next PR suggesting to remove ###***===--- because it is weird.
There was a problem hiding this comment.
i changed it to make in configurable
.../main/java/org/apache/wicket/core/request/handler/ListenerInvocationNotAllowedException.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/wicket/core/request/handler/ListenerInvocationNotAllowedException.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * Configure noisy Logging in Exceptions | ||
| */ | ||
| private boolean loudExceptionLogging = true; |
There was a problem hiding this comment.
We have https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/settings/ExceptionSettings.java
Maybe it is a better place for this new setting ?!
…er/ListenerInvocationNotAllowedException.java Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
…er/ListenerInvocationNotAllowedException.java Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
wicket-core/src/main/java/org/apache/wicket/settings/ExceptionSettings.java
Outdated
Show resolved
Hide resolved
martin-g
changed the title
...t/java/org/apache/wicket/core/request/handler/ListenerInvocationNotAllowedExceptionTest.java
Show resolved
Hide resolved
|
Thank you, @renoth ! |
RequestCycle logs ******* which does produce some unnecessary noise in log aggregators like Kibana