Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to blog post on C/C NA BOF #129

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Add link to blog post on C/C NA BOF #129

merged 2 commits into from
Oct 17, 2024

Conversation

epugh
Copy link
Contributor

@epugh epugh commented Oct 13, 2024

No description provided.

@epugh epugh changed the title Add link to blog post on bof Add link to blog post on C/C NA BOF Oct 13, 2024
Copy link

@stefanvodita stefanvodita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for writing this @epugh! I saw the previous BoF blogpost (#110) had a build failure as well. Is it the same as here and not really an issue? Approving under that assumption.

Copy link
Contributor

@gerlowskija gerlowskija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least one typo, and maybe some tweaks to the external post itself.

(Should I be reviewing the external post? Is that unwelcome? Apologies if I'm being nosy! 😬 )

# Community Over Code NA 2024 Apache Lucene/Solr Birds Of A Feather
Dive into the insights and key takeaways from the Apache Lucene/Solr Birds of a Feather (BoF) session at Community Over Code EU 2024, held in the mile high city of Denver, Colorado. This session was specially organized to gather feedback from the community, fostering a collaborative environment where developers, users, and enthusiasts could share their experiences and insights.

Read about the brainstorming that took place during the event to shape the future of these Apache projects - the complete post can be read here: [Community Over Code NA 2024 Apache Lucene/Solr Birds Of A Feather](https://dep4b.hashnode.dev/community-over-code-na-2024-apache-lucenesolr-birds-of-a-feather)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Q] In these "external link" blog posts, I'm never sure whether or not to provide feedback on the external post itself, or limit my review to just this little blurb.

But if the "external post" is in scope, a few comments:

What should we know about Lucene 10?

Putting "Knn Capabilities" in the list that follows the "Lucene 10" lead in implies that Lucene's Knn support is new in 10, when really it's existed since 9.0 or so.

I have similar concerns about the mention of "Binary Partitioning" in a section titled "What's coming up in Lucene in the next 2 years?" AFAIK binary-partitioning is already available, and doesn't really make sense there...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll tweak some text in the blog post!

@gerlowskija
Copy link
Contributor

I saw the previous BoF blogpost (#110) had a build failure as well. Is it the same as here and not really an issue?

Looks like the "action" fails trying to install a "pip" package. Presumably we should be using a virtualenv or something similar if we need to install those? Not sure how this build would've ever passed though.

In any case it looks unrelated to this PR - FWIW I've pulled the PR down locally and can attest that a similar build passes for me there 🤷

@epugh
Copy link
Contributor Author

epugh commented Oct 14, 2024

thanks for feedback.. I'd love a +1 or even a merge to get this done and out the door ;-)

@epugh epugh merged commit 5eff80e into main Oct 17, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants