Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pekko 1.1.2 #382

Merged
merged 2 commits into from
Oct 8, 2024
Merged

pekko 1.1.2 #382

merged 2 commits into from
Oct 8, 2024

Conversation

pjfanning
Copy link
Contributor

No description provided.

raboof
raboof approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we manually adding these instead of leaving this up to scala-steward again? was there some technical issue?

@pjfanning
Copy link
Contributor Author

pjfanning commented Oct 8, 2024 •
edited
Loading

why are we manually adding these instead of leaving this up to scala-steward again? was there some technical issue?

ScalaSteward has no inkling of how PekkoCoreDependency.scala and sbt-pekko-build works. It has attempted to produce PRs in some repos that were very broken.

Example PR where ScalaSteward became very confused and suggested PRs that updated the wrong versions for the wrong modules.

https://github.com/apache/pekko-projection/pull/203/files

@pjfanning pjfanning merged commit 1080524 into main Oct 8, 2024
22 checks passed
@pjfanning pjfanning deleted the pjfanning-patch-2 branch October 8, 2024 15:33
@raboof
Copy link
Member

raboof commented Oct 8, 2024

why are we manually adding these instead of leaving this up to scala-steward again? was there some technical issue?

ScalaSteward has no inkling of how PekkoCoreDependency.scala and sbt-pekko-build works. It has attempted to produce PRs in some repos that were very broken.

Example PR where ScalaSteward became very confused and suggested PRs that updated the wrong versions for the wrong modules.

https://github.com/apache/pekko-projection/pull/203/files

lol that was indeed less smart than I expected 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjfanning @raboof