Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sbt-header to code style checks #208

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

mdedetrich
Copy link
Contributor

Forgot to do this in previous PR

Copy link
Contributor

@nvollmar nvollmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

build.sbt Outdated Show resolved Hide resolved
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to change and add +

@mdedetrich mdedetrich force-pushed the add-header-to-codestyle-checks branch from 4385eba to 5b24ecc Compare August 12, 2023 08:12
@mdedetrich mdedetrich requested a review from He-Pin August 12, 2023 08:13
@mdedetrich
Copy link
Contributor Author

need to change and add +

@He-Pin fixed

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

build.sbt Outdated
@@ -129,8 +129,8 @@ lazy val `pekko-connectors` = project
crossScalaVersions := List() // workaround for https://github.com/sbt/sbt/issues/3465
)

addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll")
addCommandAlias("checkCodeStyle", ";scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll; +headerCheckAll")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+headerCreateAll

build.sbt Outdated Show resolved Hide resolved
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to update it

build.sbt Outdated Show resolved Hide resolved
@mdedetrich mdedetrich force-pushed the add-header-to-codestyle-checks branch from 5b24ecc to 697695d Compare August 15, 2023 08:56
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdedetrich mdedetrich merged commit 329eaa8 into apache:main Aug 15, 2023
50 checks passed
@mdedetrich mdedetrich deleted the add-header-to-codestyle-checks branch August 15, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants