[MRELEASE-1154] Improve exception message for unresolvable version

expressions
apache · Aug 27, 2024 · b4aedda · b4aedda
1 parent befc778
commit b4aedda
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/...manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java b/...manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java
@@ -616,16 +616,17 @@ private void rewriteArtifactVersions(
                                                     + rawVersion);
                                 } else {
                                     // the expression used to define the version of this artifact may be inherited
-                                    // TODO needs a better error message, what pom? what dependency?
                                     throw new ReleaseFailureException(
-                                            "Could not find property resolving version expression: " + rawVersion);
+                                            "Could not find property resolving version expression: " + rawVersion
+                                                    + " for artifact " + key + " in the project " + projectId
+                                                    + ".");
                                 }
                             }
                         } else {
                             // the expression used to define the version of this artifact may be inherited
-                            // TODO needs a better error message, what pom? what dependency?
                             throw new ReleaseFailureException(
-                                    "Could not find properties resolving version expression : " + rawVersion);
+                                    "Could not find properties resolving version expression : " + rawVersion
+                                            + " for artifact " + key + " in the project " + projectId + ".");
                         }
                     } else {
                         // different/previous version not related to current release