SMB v. 2 / 3 integration based on SMBJ #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed: getParent() when share root is reached
go through cached files to check whether parent is already resolved
Removed RandomAccess from capabilities Added getLastModifiedTime Tests: testLoadClass & testSealing are not working on linux (it seems to be an known issue)
needs FullControl
Added Exceptions in Resources.properties and replaced all exceptions with the correct ressource
|
@markt-asf , can I ask why did you close it ? was it integrated in some other way to this repository ? |
|
It was closed automatically when the trunk branch was removed. I've re-opened the PR. Please re-base it against master. |
michael-o
requested changes
Sep 18, 2019
| <dependency> | ||
| <groupId>org.slf4j</groupId> | ||
| <artifactId>slf4j-simple</artifactId> | ||
| <version>1.5.11</version> |
| <!-- https://mvnrepository.com/artifact/org.slf4j/slf4j-simple --> | ||
| <dependency> | ||
| <groupId>org.slf4j</groupId> | ||
| <artifactId>slf4j-simple</artifactId> |
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| --> | ||
| <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor |
There was a problem hiding this comment.
You completely broke formatting.
| @@ -0,0 +1 @@ | |||
| /SMB3FileNameParser.java | |||
| sb.append("://"); | ||
| sb.append(getUserName()); | ||
| sb.append(':'); | ||
| sb.append(getPassword()); |
| StringBuilder sb = new StringBuilder(); | ||
| sb.append(getScheme()); | ||
| sb.append("://"); | ||
| sb.append(getUserName()); |
|
|
||
| private static final SMB2FileNameParser INSTANCE = new SMB2FileNameParser(); | ||
|
|
||
| private static final int PORT = 443; |
There was a problem hiding this comment.
Since when does SMB use HTTPS?
| { | ||
| if(shareName == null || shareName.length() == 0) | ||
| { | ||
| throw new Exception("No path provided!"); |
There was a problem hiding this comment.
NullPointerException and IllegalArgumentException
| String tmp = path.startsWith("/") ? path.substring(1) : path; | ||
|
|
||
| if(!tmp.substring(0, shareName.length()).equals(shareName)) { | ||
| throw new Exception("Share does not match the provided path!"); |
|
@ahbonsu @markt-asf - can you please advise if this planned to be merged ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
based on this issue: https://issues.apache.org/jira/browse/VFS-635 I created an implementation of https://github.com/hierynomus/smbj into vfs 2.2
I named the provider SMB2, so the scheme I used is also smb2. I dont know if it's better to rename the existing smb to cifs and use smb for the smb v2+ implementation.
All the tests from the ProviderTests pass (except known issues with classLoader ans sealedClass).
Thanks for any feedback or further advice how to proceed with this pr,
André