Py runtime: Move to relative imports #4705
Open
+234
−232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelson
force-pushed
the
feature/pyruntime-imports
branch
from
3bd8e91
to
8d82b49
Compare
pelson
commented
Sep 29, 2024
pelson
commented
Sep 29, 2024
|
@pelson thanks for this. LGTM apart from my 2 comments. |
|
Thanks @ericvergnaud - I think you forgot to hit submit review. Comments missing. |
pelson
commented
Sep 30, 2024
ericvergnaud
requested changes
Sep 30, 2024
| @@ -1,5 +1,11 @@ | |||
| # Generated from XPathLexer.g4 by ANTLR 4.13.1 | |||
| from antlr4 import * | |||
| from ..Lexer import Lexer | |||
There was a problem hiding this comment.
This file is generated, and generated files cannot use relative imports since they normally sit outside the antlr code base. Please revert
Signed-off-by: Phil Elson <pelson.pub@gmail.com>
pelson
force-pushed
the
feature/pyruntime-imports
branch
from
8d82b49
to
06417ca
Compare
ericvergnaud
requested changes
Oct 11, 2024
| @@ -165,7 +164,3 @@ def process(input_stream, class_lexer, class_parser): | |||
| process(input_stream, class_lexer, class_parser) | |||
| else: | |||
| print("[ERROR] file {} not exist".format(os.path.normpath(file_name))) | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a few
from antlr4 import *, which is considered bad practice unless being done to expose an interface (https://peps.python.org/pep-0008/#imports)My changes seem to modify generated files in
antlr4.xpath. I didn't yet look at fixing the generator.There remains some significant issues withe the namespaces being exposed in the runtime - I would be happy to follow up after this change to tighten the names being made publicly available.