Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gateway support to awxkit #15576

Merged
merged 3 commits into from
Oct 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions awxkit/awxkit/api/pages/base.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import collections
import logging
import typing

from requests.auth import HTTPBasicAuth

Expand All @@ -12,6 +13,11 @@
log = logging.getLogger(__name__)


class AuthUrls(typing.TypedDict):
access_token: str
personal_token: str


class Base(Page):
def silent_delete(self):
"""Delete the object. If it's already deleted, ignore the error"""
Expand Down Expand Up @@ -141,30 +147,27 @@

load_default_authtoken = load_authtoken

def get_oauth2_token(self, username='', password='', client_id=None, description='AWX CLI', client_secret=None, scope='write'):
default_cred = config.credentials.default
username = username or default_cred.username
password = password or default_cred.password
def _request_token(self, auth_urls, username, password, client_id, description, client_secret, scope):
req = collections.namedtuple('req', 'headers')({})
if client_id and client_secret:
HTTPBasicAuth(client_id, client_secret)(req)
req.headers['Content-Type'] = 'application/x-www-form-urlencoded'
resp = self.connection.post(
f"{config.api_base_path}o/token/",
auth_urls["access_token"],
data={"grant_type": "password", "username": username, "password": password, "scope": scope},
headers=req.headers,
)
elif client_id:
req.headers['Content-Type'] = 'application/x-www-form-urlencoded'
resp = self.connection.post(
f"{config.api_base_path}o/token/",
auth_urls["access_token"],
data={"grant_type": "password", "username": username, "password": password, "client_id": client_id, "scope": scope},
headers=req.headers,
)
else:
HTTPBasicAuth(username, password)(req)
resp = self.connection.post(
'{0}v2/users/{1}/personal_tokens/'.format(config.api_base_path, username),
auth_urls['personal_token'],
json={"description": description, "application": None, "scope": scope},
headers=req.headers,
)
Expand All @@ -177,6 +180,21 @@
else:
raise exception_from_status_code(resp.status_code)

def get_oauth2_token(self, username='', password='', client_id=None, description='AWX CLI', client_secret=None, scope='write'):
default_cred = config.credentials.default
username = username or default_cred.username
password = password or default_cred.password

Check warning on line 186 in awxkit/awxkit/api/pages/base.py

View check run for this annotation

Codecov / codecov/patch

awxkit/awxkit/api/pages/base.py#L184-L186

Added lines #L184 - L186 were not covered by tests
# Try gateway first, fallback to controller
urls: AuthUrls = {"access_token": "/o/token/", "personal_token": f"{config.gateway_base_path}v1/tokens/"}
try:
return self._request_token(urls, username, password, client_id, description, client_secret, scope)
except exc.NotFound:
urls = {

Check warning on line 192 in awxkit/awxkit/api/pages/base.py

View check run for this annotation

Codecov / codecov/patch

awxkit/awxkit/api/pages/base.py#L188-L192

Added lines #L188 - L192 were not covered by tests
"access_token": f"{config.api_base_path}o/token/",
"personal_token": f"{config.api_base_path}v2/users/{username}/personal_tokens/",
}
return self._request_token(urls, username, password, client_id, description, client_secret, scope)

Check warning on line 196 in awxkit/awxkit/api/pages/base.py

View check run for this annotation

Codecov / codecov/patch

awxkit/awxkit/api/pages/base.py#L196

Added line #L196 was not covered by tests

def load_session(self, username='', password=''):
default_cred = config.credentials.default
self.connection.login(
Expand Down
1 change: 1 addition & 0 deletions awxkit/awxkit/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,4 @@ def getvalue(self, name):
config.prevent_teardown = to_bool(os.getenv('AWXKIT_PREVENT_TEARDOWN', False))
config.use_sessions = to_bool(os.getenv('AWXKIT_SESSIONS', False))
config.api_base_path = os.getenv('AWXKIT_API_BASE_PATH', '/api/')
config.gateway_base_path = os.getenv('AWXKIT_GATEWAY_BASE_PATH', '/api/gateway/')
59 changes: 59 additions & 0 deletions awxkit/test/api/pages/test_base.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
from http.client import NOT_FOUND
import pytest
from pytest_mock import MockerFixture
from requests import Response

from awxkit.api.pages import Base
from awxkit.config import config


@pytest.fixture(autouse=True)
def setup_config(monkeypatch: pytest.MonkeyPatch) -> None:
monkeypatch.setattr(config, "credentials", {"default": {"username": "foo", "password": "bar"}}, raising=False)
monkeypatch.setattr(config, "base_url", "", raising=False)


@pytest.fixture
def response(mocker):
r = mocker.Mock()
r.status_code = NOT_FOUND
r.json.return_value = {
"token": "my_personal_token",
"access_token": "my_token",
}
return r


@pytest.mark.parametrize(
("auth_creds", "url", "token"),
[
({"client_id": "foo", "client_secret": "bar"}, "/o/token/", "my_token"),
({"client_id": "foo"}, "/o/token/", "my_token"),
({}, "/api/gateway/v1/tokens/", "my_personal_token"),
],
)
def test_get_oauth2_token_from_gateway(mocker: MockerFixture, response: Response, auth_creds, url, token):
post = mocker.patch("requests.Session.post", return_value=response)
base = Base()
ret = base.get_oauth2_token(**auth_creds)
assert post.call_count == 1
assert post.call_args.args[0] == url
assert ret == token


@pytest.mark.parametrize(
("auth_creds", "url", "token"),
[
({"client_id": "foo", "client_secret": "bar"}, "/api/o/token/", "my_token"),
({"client_id": "foo"}, "/api/o/token/", "my_token"),
({}, "/api/v2/users/foo/personal_tokens/", "my_personal_token"),
],
)
def test_get_oauth2_token_from_controller(mocker: MockerFixture, response: Response, auth_creds, url, token):
type(response).ok = mocker.PropertyMock(side_effect=[False, True])
post = mocker.patch("requests.Session.post", return_value=response)
base = Base()
ret = base.get_oauth2_token(**auth_creds)
assert post.call_count == 2
assert post.call_args.args[0] == url
assert ret == token
Loading