Rewrite more access logic in terms of permissions instead of roles #15453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1 task
fosterseth
approved these changes
Aug 21, 2024
fosterseth
pushed a commit
to fosterseth/awx
that referenced
this pull request
Aug 30, 2024
…nsible#15453) (ansible#6661) * Rewrite more access logic in terms of permissions instead of roles * Cut down supported logic because that would not work anyway * Remove methods not needed anymore * Create managed roles in test before delegating permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We have these "old" patterns in the ORM based on the old RBAC models, and then we have "new" patterns, those coming from DAB RBAC.
These needed to be migrated anyway, but I believe I may have hit an issue in ansible/django-ansible-base#562 where we checked for the "member_role" specifically, but multiple roles can convey the "member" permission in the new parlance.
ISSUE TYPE
COMPONENT NAME