Fixes pytest CI error #15435
Merged
Fixes pytest CI error #15435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` /var/lib/awx/venv/awx/lib64/python3.11/site-packages/_pytest/python.py:163: PytestReturnNotNoneWarning: Expected None, but awx/main/tests/unit/test_tasks.py::TestJobCredentials::test_custom_environment_injectors_with_boolean_extra_vars returned ['successful', 0], which will be an error in a future version of pytest. Did you mean to use `assert` instead of `return`? ``` * Dug into the git blame for this one 0605854 is the commit for any historians. It was wrongfully carried over from a mock pexpect implementation. Our new tests are nice. They don't go as far as trying to run the task so they do not need to mock pexpect. That is why it is safe to remove this code without finding it a new home.
|
AlanCoding
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION