Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new OpenShift Virtualization inventory source to docs. #15299

Merged
merged 6 commits into from
Jul 1, 2024

Conversation

tvo318
Copy link
Member

@tvo318 tvo318 commented Jun 25, 2024

SUMMARY

Adds new inventory source docs for OpenShit Virtualization. Addresses issue #15274.

See rendered version here: https://ansible--15299.org.readthedocs.build/projects/awx/en/15299/userguide/inventories.html#openshift-virtualization

ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • Docs
AWX VERSION

latest

@@ -481,7 +481,7 @@ Inventory updates use dynamically-generated YAML files which are parsed by their
- :ref:`ug_source_openstack`
- :ref:`ug_source_rhv`
- :ref:`ug_source_rhaap`
- :ref:`ug_source_terraform`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I must have accidentally typed over it instead of copying an entry for the new one.


5. Save the configuration and click the **Sync** button to sync the inventory.

As the sync runs, the results display in the job run output window. To access the job output while it is running, you can click on the spinning "Running" icon next to the **Last Job Status** field.
Copy link
Member

@fosterseth fosterseth Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this paragraph and the image below is necessary to include. This statement is not specific to this credential and would be the case for all the other inventory updates too.


3. You can optionally specify the verbosity, host filter, enabled variable/value, and update options as described in the main procedure for :ref:`adding a source <ug_add_inv_common_fields>`.

4. Use the **Source Variables** field to override variables used by the ``controller`` inventory plugin. Enter variables using either JSON or YAML syntax. Use the radio button to toggle between the two. For more information on these variables, see the `Kubernetes (K8s) inventory source <https://github.com/ansible-collections/kubernetes.core/blob/main/docs/kubernetes.core.k8s_inventory.rst>`_ documentation for detail.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ansible-collections/community.kubevirt
here's the repo for the correct collection containing the inventory plugin

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tvo318 tvo318 requested a review from TheRealHaoLiu July 1, 2024 14:20
@tvo318 tvo318 merged commit 6763bad into ansible:devel Jul 1, 2024
21 checks passed
chrismeyersfsu added a commit to chrismeyersfsu/awx that referenced this pull request Jul 3, 2024
@tvo318 tvo318 deleted the ocpv branch July 15, 2024 19:30
djyasin pushed a commit to djyasin/awx that referenced this pull request Sep 16, 2024
…#15299)

* Added new OpenShift Virtualization inventory source to docs.

* Incorporated review feedback from @fosterseth and @TheRealHaoLiu.

* Fixed link to correct kubevirt.core.kubevirt documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants